Chore: upgrade grafana deps #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryantxu
commented
Nov 10, 2022
| @@ -395,7 +395,8 @@ export class QueryEditor extends PureComponent<Props, State> { | |||
| if (!this.props.datasource.grafanaLiveEnabled) { | |||
| return null; | |||
| } | |||
|
|
|||
| // Fixing weird typing issue | |||
| const FVM = FieldValidationMessage as any; | |||
There was a problem hiding this comment.
This one is weird 😬 --in 9x it is ok, but the 8.3x part has weird inherited types that do not expect childe attributes.
hwandersman
reviewed
Nov 10, 2022
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "grafana-iot-twinmaker-app", | |||
| "version": "1.2.1", | |||
| "version": "1.3.0-pre", | |||
There was a problem hiding this comment.
What's the reason for bumping the version now?
There was a problem hiding this comment.
🤔 -- really depends how we want to use main, but given that main is the next version, not the last version, i think it is better to bump sooner than later (it is weird to have dev artifacts with the same version as the previous release!)
hwandersman
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should have no real runtime effects, but is bumping most of the build dependencies.