Add templates and workflows for AWS Plugins squad #156
Conversation
|
|
|
Levitate is-compatible report: 🔍 Resolving @grafana/data@latest... 🔬 Checking compatibility between ./src/module.ts and @grafana/data@9.3.6... 🔬 Checking compatibility between ./src/module.ts and @grafana/ui@9.3.6... 🔬 Checking compatibility between ./src/module.ts and @grafana/runtime@9.3.6... 🔬 Checking compatibility between ./src/module.ts and @grafana/e2e-selectors@9.3.6... ✔️ ./src/module.ts appears to be compatible with @grafana/data,@grafana/ui,@grafana/runtime,@grafana/e2e-selectors |
fridgepoet
requested review from
a team,
iwysiu and
idastambuk
and removed request for
a team
| { | ||
| "type": "label", | ||
| "name": "datasource/TwinMaker", | ||
| "action": "addToProject", |
There was a problem hiding this comment.
could we add the commands for "removeFromProject" too? e.g. https://github.com/grafana/grafana/blob/main/.github/commands.json#L209
There was a problem hiding this comment.
I'm not really sure when this is called/used. Could you explain that?
So I added one entry for both existing entries with addToProject. Was that right?
There was a problem hiding this comment.
ex: I add the label "datasource/TwinMaker" to a ticket, I want it to get added to our kanban board, if I remove "datasource/TwinMaker" it would remove it from our board...not sure how much this really comes up in our workflow, but we tend to do this lol
There was a problem hiding this comment.
Just tried this out here #159 (you can see I've added the label, saw it add to our board). I removed datasource/TwinMaker and pretty sure it's still stuck on our board
There was a problem hiding this comment.
Nevermind it's gone now!
There was a problem hiding this comment.
Nevermind I was wrong! It has not been removed from our project board.
|
Backend code coverage report for PR #156 |
|
Frontend code coverage report for PR #156 |
Contributes to #153
Special notes:
I've reduced the
buildscript in thepackage.json. While adding the Compatibility Check, the build kept failing from running out of memory. I was unable to successfully build without removing the extra commands (see commit history and corresponding runs). Thisbuildscript is now similar to our other repos -- please let me know if that's alright.Also I think none of our other repos have PR templates. I've added one here which I think could be nice to add to our other repos.