Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Migrate to create-plugin #160

Merged
merged 11 commits into from
Feb 6, 2023
Merged

Conversation

jackw
Copy link
Contributor

@jackw jackw commented Feb 2, 2023

What this PR does / why we need it:
Migrates away from toolkit to create-plugin.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@github-actions
Copy link

github-actions bot commented Feb 2, 2023

Levitate is-compatible report:

🔍 Resolving @grafana/data@latest...
🔍 Resolving @grafana/ui@latest...
🔍 Resolving @grafana/runtime@latest...
🔍 Resolving @grafana/e2e-selectors@latest...

🔬 Checking compatibility between ./src/module.ts and @grafana/data@9.3.6...
✔ Found @grafana/data version 8.4.11 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/ui@9.3.6...
✔ Found @grafana/ui version 8.4.11 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/runtime@9.3.6...
✔ Found @grafana/runtime version 8.4.11 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/e2e-selectors@9.3.6...
✔ Found @grafana/e2e-selectors version 8.4.11 locally

✔️ ./src/module.ts appears to be compatible with @grafana/data,@grafana/ui,@grafana/runtime,@grafana/e2e-selectors

@iwysiu iwysiu self-assigned this Feb 3, 2023
@iwysiu iwysiu marked this pull request as ready for review February 3, 2023 20:34
@iwysiu iwysiu requested a review from a team as a code owner February 3, 2023 20:34
@iwysiu iwysiu requested review from idastambuk and kevinwcyu and removed request for a team February 3, 2023 20:34
@iwysiu
Copy link
Contributor

iwysiu commented Feb 3, 2023

It currently fails the code coverage workflow because code coverage isn't available on main, thus it fails that step.

@idastambuk
Copy link
Contributor

It currently fails the code coverage workflow because code coverage isn't available on main, thus it fails that step.

Is this the step that @fridgepoet merged a few days ago? If it is, maybe a rebase would be good to check if it all passes?

@fridgepoet
Copy link
Member

@idastambuk I'll have a look and see if I can add the missing test coverage script to the package.json

@github-actions
Copy link

github-actions bot commented Feb 6, 2023

Backend code coverage report for PR #160
No changes

@github-actions
Copy link

github-actions bot commented Feb 6, 2023

Frontend code coverage report for PR #160

Plugin Main PR Difference
src 8.98% 44.59% 35.61%

@iwysiu iwysiu changed the title [WIP] Chore: Migrate to create-plugin Chore: Migrate to create-plugin Feb 6, 2023
@iwysiu iwysiu merged commit eab33f9 into main Feb 6, 2023
@iwysiu iwysiu deleted the jackw/migrate-to-create-plugin branch February 6, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants