Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update backend packages #180

Merged
merged 3 commits into from
Apr 20, 2023
Merged

Update backend packages #180

merged 3 commits into from
Apr 20, 2023

Conversation

fridgepoet
Copy link
Member

@fridgepoet fridgepoet requested a review from a team as a code owner April 19, 2023 15:18
@github-actions
Copy link

Backend code coverage report for PR #180
No changes

@github-actions
Copy link

Frontend code coverage report for PR #180
No changes

@github-actions
Copy link

github-actions bot commented Apr 19, 2023

Levitate is-compatible report:

🔍 Resolving @grafana/data@latest...
🔍 Resolving @grafana/ui@latest...
🔍 Resolving @grafana/runtime@latest...
🔍 Resolving @grafana/e2e-selectors@latest...

🔬 Checking compatibility between ./src/module.ts and @grafana/data@9.4.7...
✔ Found @grafana/data version 8.4.11 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/ui@9.4.7...
✔ Found @grafana/ui version 8.4.11 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/runtime@9.4.7...
✔ Found @grafana/runtime version 8.4.11 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/e2e-selectors@9.4.7...
✔ Found @grafana/e2e-selectors version 8.4.11 locally

✔️ ./src/module.ts appears to be compatible with @grafana/data,@grafana/ui,@grafana/runtime,@grafana/e2e-selectors

Copy link
Contributor

@iwysiu iwysiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know why we needed the testdata changes?

@fridgepoet
Copy link
Member Author

Seems there was some change in the "experimental" package of github.com/grafana/grafana-plugin-sdk-go which generated the expected json response during the update to v0.159.0

So the re-generated expected response includes the change. Let me know if we're not comfortable just going with this; I believe it's not strictly necessary for me to update grafana-plugin-sdk-go.

@fridgepoet fridgepoet merged commit 70fbe62 into main Apr 20, 2023
2 of 3 checks passed
@fridgepoet fridgepoet deleted the v1.5.0 branch April 20, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants