Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge matterport_ga branch to main #182

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Merge matterport_ga branch to main #182

merged 1 commit into from
Apr 21, 2023

Conversation

hwandersman
Copy link
Collaborator

What this PR does / why we need it:

Prepare main for release of new features: data overlay, tag resize, matterport integration

Which issue(s) this PR fixes:

None

Fixes #

Special notes for your reviewer:

@hwandersman hwandersman requested a review from a team as a code owner April 20, 2023 21:57
@github-actions
Copy link

Backend code coverage report for PR #182
No changes

@github-actions
Copy link

Frontend code coverage report for PR #182

Plugin Main PR Difference
src 44.59% 50.89% 6.30%

@github-actions
Copy link

github-actions bot commented Apr 20, 2023

Levitate is-compatible report:

🔍 Resolving @grafana/data@latest...
🔍 Resolving @grafana/ui@latest...
🔍 Resolving @grafana/runtime@latest...
🔍 Resolving @grafana/e2e-selectors@latest...

🔬 Checking compatibility between ./src/module.ts and @grafana/data@9.4.7...
✔ Found @grafana/data version 8.4.11 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/ui@9.4.7...
✔ Found @grafana/ui version 8.4.11 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/runtime@9.4.7...
✔ Found @grafana/runtime version 8.4.11 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/e2e-selectors@9.4.7...
✔ Found @grafana/e2e-selectors version 8.4.11 locally

✔️ ./src/module.ts appears to be compatible with @grafana/data,@grafana/ui,@grafana/runtime,@grafana/e2e-selectors

@fridgepoet
Copy link
Member

fridgepoet commented Apr 21, 2023

Hi there, I'm noticing an error on the Video Player that I don't see on main
TypeError: (0 , aws_sdk_service_error_classification__WEBPACK_IMPORTED_MODULE_1_.isServerError) is not a function

Screenshot 2023-04-21 at 10 05 05

Are you all seeing this too?

@mukeshsahay
Copy link
Collaborator

Hi there, I'm noticing an error on the Video Player that I don't see on main TypeError: (0 , aws_sdk_service_error_classification__WEBPACK_IMPORTED_MODULE_1_.isServerError) is not a function

Screenshot 2023-04-21 at 10 05 05

Are you all seeing this too?

I don't see this issue. Video Player is working fine.

VideoPlayerTest.mov

@mukeshsahay mukeshsahay merged commit 974a45e into main Apr 21, 2023
3 checks passed
@mukeshsahay mukeshsahay deleted the matterport_ga branch April 21, 2023 16:03
@fridgepoet
Copy link
Member

great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants