Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix npm audit vulnerabilities using resolutions #183

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Conversation

TheEvilDev
Copy link
Collaborator

What this PR does / why we need it:

Which issue(s) this PR fixes:

Our internal security team noted that we have potential vulnerabilities in our devDependencies. These stem from nested dependencies in @grafana and @iot-app-kit package dependencies.

For most of the vulnerabilities, they were patched in very similar versions to what's already in the dependency chain, so this shouldn't cause much of an issue.

For these 2 dependencies, there was a significant shift in Major version, but from testing doesn't seem to impact the build of the customer application, so may appear when we run our automated tests, submitting this PR to find out.

    "d3-color": "^3.1.0",
    "log4js": "^6.4.0"

Fixes #

Special notes for your reviewer:

@CLAassistant
Copy link

CLAassistant commented Apr 24, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

Backend code coverage report for PR #183
No changes

@github-actions
Copy link

Frontend code coverage report for PR #183
No changes

@github-actions
Copy link

github-actions bot commented Apr 24, 2023

Levitate is-compatible report:

🔍 Resolving @grafana/data@latest...
🔍 Resolving @grafana/ui@latest...
🔍 Resolving @grafana/runtime@latest...
🔍 Resolving @grafana/e2e-selectors@latest...

🔬 Checking compatibility between ./src/module.ts and @grafana/data@9.4.7...
✔ Found @grafana/data version 8.4.11 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/ui@9.4.7...
✔ Found @grafana/ui version 8.4.11 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/runtime@9.4.7...
✔ Found @grafana/runtime version 8.4.11 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/e2e-selectors@9.4.7...
✔ Found @grafana/e2e-selectors version 8.4.11 locally

✔️ ./src/module.ts appears to be compatible with @grafana/data,@grafana/ui,@grafana/runtime,@grafana/e2e-selectors

@hwandersman hwandersman marked this pull request as ready for review April 24, 2023 20:52
@hwandersman hwandersman requested a review from a team as a code owner April 24, 2023 20:52
@TheEvilDev TheEvilDev enabled auto-merge (squash) April 24, 2023 21:39
@TheEvilDev TheEvilDev merged commit 796c1e5 into main Apr 25, 2023
3 checks passed
@TheEvilDev TheEvilDev deleted the NpmAudit branch April 25, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants