Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config editor: Migrate to new form styling under feature toggle #244

Merged
merged 1 commit into from Nov 20, 2023

Conversation

idastambuk
Copy link
Contributor

What this PR does / why we need it:
Migrating Config Editor to the new design system form components
The new components are under a Grafana feature flag awsDatasourcesNewFormStyling.

Config Editor

What was done
Replace the editor inline fields for the grafana/ui Field components if the feature flag is enabled
Screenshot 2023-10-30 at 5 51 54 PM
Screenshot 2023-10-30 at 4 14 12 PM
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@idastambuk idastambuk requested a review from a team as a code owner November 13, 2023 12:02
@idastambuk idastambuk changed the title Migrate Config Editor to new form styling under a feature toggle Config editor: Migrate to new form styling under feature toggle Nov 13, 2023
@idastambuk idastambuk merged commit 92d68d3 into main Nov 20, 2023
4 checks passed
@idastambuk idastambuk deleted the config-editor-migration branch November 20, 2023 10:34
@idastambuk idastambuk mentioned this pull request Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants