Query editor: Migrate to new form styling under feature toggle #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahzinger
approved these changes
Nov 16, 2023
idastambuk
force-pushed
the
query-editor-migration
branch
from
58675f4
to
e6a074e
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Migrating Query Editor to use EditorField components from grafana/experimental.
The new components are under a Grafana feature flag
awsDatasourcesNewFormStyling.Query Editor
What was done
I did this because they were squeezed after other fields, like Component Name, and weren't that visible either. But if there's a strong reason for these being accessible right after the fields, I can put them back.
Screen.Recording.2023-10-30.at.4.14.35.PM.mov
Which issue(s) this PR fixes:
Fixes https://github.com/grafana/oss-plugin-partnerships/issues/633
Special notes for your reviewer: