Config editor: Fix workspace loading in new form styling and prepare 1.10.0 #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinwcyu
approved these changes
Nov 27, 2023
idastambuk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In the old form styling, the Workspaces Select input was set to be disabled if there were no workspaces. This doesn't seem to do anything, since the default state is
[]but the user is still able to click on it. This is ok, since the fetchWorkspaces function is only called on opening the dropdown.However, in the new form styling the
disabledattribute is applied, so the user is unable to fetch workspaces for a new Twinmaker datasource. Probably should have caught this earlier, but better late than never I guess 馃様I removed the disabled attribute, since the flow works perfectly fine without it (i.e. the same as in the old form styling).
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: