Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Form Styling: improvements #268

Merged
merged 1 commit into from Jan 10, 2024
Merged

New Form Styling: improvements #268

merged 1 commit into from Jan 10, 2024

Conversation

idastambuk
Copy link
Contributor

What this PR does / why we need it:
Fixes from the new form styling bug bash

  • Disable delete button if there's only one filter and it's empty
Screenshot 2024-01-10 at 13 15 40
  • Fix capitalization in tooltip

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@idastambuk idastambuk requested a review from a team as a code owner January 10, 2024 12:20
@idastambuk idastambuk merged commit 0329bce into main Jan 10, 2024
4 checks passed
@idastambuk idastambuk deleted the form-improvements branch January 10, 2024 14:30
@idastambuk idastambuk mentioned this pull request Jan 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahzinger sarahzinger sarahzinger approved these changes

@iwysiu iwysiu Awaiting requested review from iwysiu iwysiu is a code owner automatically assigned from grafana/aws-datasources

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@idastambuk @sarahzinger