Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(appkit upgrade): Updating iot-app-kit from v9.6.0 to v10.2.0 #275

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

mumanity
Copy link
Collaborator

@mumanity mumanity commented Mar 1, 2024

What this PR does / why we need it:
@iot-app-kit dependencies are out of date & needs to be updated.

Removed mention of a TwinMaker gamma environment, and updated the datasource README with newer info about selecting a workspace.

@mumanity mumanity marked this pull request as draft March 1, 2024 17:49
@hwandersman hwandersman changed the title chore(appkit upgrade): Updating iot-app-kit/core from v9.6.0 to v9.15.0 chore(appkit upgrade): Updating iot-app-kit from v9.6.0 to v10.2.0 Apr 15, 2024
@hwandersman hwandersman marked this pull request as ready for review April 15, 2024 15:27
@hwandersman hwandersman requested a review from a team as a code owner April 15, 2024 15:27
Copy link
Contributor

@iwysiu iwysiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the change looks fine, but when I tried to build it with yarn dev I got errors about it not being able to find the @smithy/util-endpoints and @aws-sdk/region-config-resolver modules. Is it building for you?

@hwandersman
Copy link
Collaborator

Overall the change looks fine, but when I tried to build it with yarn dev I got errors about it not being able to find the @smithy/util-endpoints and @aws-sdk/region-config-resolver modules. Is it building for you?

Yes this builds for me. I am using yarn v1.22.19 and node v18.13.0.

Copy link
Contributor

@iwysiu iwysiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I was able to get it to build, approved!

@hwandersman hwandersman merged commit 29c8371 into main Apr 16, 2024
4 checks passed
@hwandersman hwandersman deleted the appkit-upgrade branch April 16, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants