Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: use drone.yml for CI #4

Merged
merged 1 commit into from
Dec 2, 2021
Merged

Chore: use drone.yml for CI #4

merged 1 commit into from
Dec 2, 2021

Conversation

atifali
Copy link
Contributor

@atifali atifali commented Dec 2, 2021

this does the following:

  • signs the drone.yml
  • allows using drone.yml for CI

atifali
atifali commented Dec 2, 2021
View reviewed changes
Copy link
Contributor Author

@atifali atifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this still uses a custom ci image for the build related steps - lets merge this in for now - once the core ci image is updated to use the latest node version we can just switch to using the standard plugin.json based build pipeline here too

@ryantxu ryantxu merged commit 715b733 into main Dec 2, 2021
@YusakuNo1 YusakuNo1 mentioned this pull request Feb 17, 2022
Closed
@mukeshsahay mukeshsahay deleted the drone-ci branch January 24, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantxu ryantxu ryantxu approved these changes

@hwandersman hwandersman Awaiting requested review from hwandersman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@atifali @ryantxu