Chore: update go version #53
Conversation
| github.com/patrickmn/go-cache v2.1.0+incompatible | ||
| github.com/stretchr/testify v1.7.0 | ||
| ) | ||
|
|
||
| require ( | ||
| github.com/apache/arrow/go/arrow v0.0.0-20211112161151-bc219186db40 // indirect |
There was a problem hiding this comment.
Do we need to list these indirect dependencies? My understanding is that after installing them into go.sum you can remove them from go.mod.
| @@ -1,12 +1,68 @@ | |||
| module github.com/grafana/grafana-iot-twinmaker-app | |||
|
|
|||
| go 1.16 | |||
| go 1.17 | |||
There was a problem hiding this comment.
Any reason this isn't 1.18?
There was a problem hiding this comment.
This signifies the minimum version that a user would need to run this package, so either 1.17 or 1.18 is fine, unless there is preference for either.
|
|
|
We no longer need this PR as we are now releasing with go 1.18 |
try building with go 1.18
Related to issue #49