Update to use new SceneViewer events #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hwandersman
reviewed
Aug 16, 2022
| selectedEntityValue && selectedComponentValue | ||
| ? { | ||
| [DataBindingLabelKeys.entityId]: selectedEntityValue, | ||
| [DataBindingLabelKeys.componentName]: selectedComponentValue, |
There was a problem hiding this comment.
Why don't we set the selected propertyName?
There was a problem hiding this comment.
we did not use it to match the data binding, so I just removed it
| } | ||
| : undefined; | ||
|
|
||
| const selectedNode = getSceneNodeByRef(getSelectedSceneNodeRef() || ''); |
There was a problem hiding this comment.
Do we always use nested function calls to get the selectedNode? What use case is there to use just one of these functions?
Seems like we don't need to return both from useSceneComposerApi
There was a problem hiding this comment.
getSceneNodeByRef should be a useful function to be exposed on it's own, so I just make them separate ones
sheilaXu
force-pushed
the
new-scene-viewer-events
branch
from
de04a21
to
e157bdf
Compare
mukeshsahay
approved these changes
Sep 20, 2022
|
Known bugs for camera position and video playback mode. to be fixed with next PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.