extend alarm list to support basic and sitewise alarm extensions #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheEvilDev
approved these changes
Aug 23, 2022
mukeshsahay
approved these changes
Aug 23, 2022
msshui-amzn
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We PR 84 for how to test alarm configuration (#84).
Current TwinMaker API only allows for direct child to be search for by list-component-types API when using the extendsFrom. Thus to enable finding extensions of both the basic alarm and the new sitewise 1p alarm we need to do two queries even though the sitewise 1P alarm component type is extended from the twinmaker basic alarm component type.
This was testing using entities that have 2 alarms of the same componentType on the same entity which exposed an issue with an extra 'break' in the utils.go that caused the search to exit on the first matching componentType even if the externalId didn't match.