Updated dashboard datasource readme #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwandersman
reviewed
Aug 29, 2022
src/datasource/README.md
Outdated
| @@ -12,15 +12,15 @@ | |||
| 2. The same credentials are used on the browser for our custom panels, so make sure your permissions are scoped down | |||
| 3. EC2 users: you can use “AWS SDK Default” to resolve credentials from your instance IAM role. It is a security risk to expose these credentials on your browser so you MUST set an additional IAM role with scoped down permissions. See [here](https://docs.aws.amazon.com/STS/latest/APIReference/API_AssumeRole.html) for information on setting up permissions to assume roles. | |||
|
|
|||
| 4. We recommend to set an Assume Role ARN for any environment Grafana is running in. You can create an IAM role and policies for your TwinMaker workspace. | |||
| 4. You need to set an "Assume Role ARN" for any environment Grafana is running in. You need to create an IAM role and policies for your TwinMaker workspace. | |||
There was a problem hiding this comment.
Let's link to our documentation: https://docs.aws.amazon.com/iot-twinmaker/latest/guide/dashboard-IAM-role.html
There was a problem hiding this comment.
I added the link.
msshui-amzn
force-pushed
the
update-dashboard-role-readme
branch
from
f5f12b0
to
9af2367
Compare
msshui-amzn
force-pushed
the
update-dashboard-role-readme
branch
from
9af2367
to
67a389a
Compare
hwandersman
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that the "Assumer role ARN" is now required, we need to update the README to reflect this.