Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kiosk local login broken #7

Closed
jortkoopmans opened this issue Oct 7, 2019 · 18 comments
Closed

kiosk local login broken #7

jortkoopmans opened this issue Oct 7, 2019 · 18 comments
Assignees
Labels
bug Something isn't working

Comments

@jortkoopmans
Copy link
Contributor

jortkoopmans commented Oct 7, 2019

Grafana: 6.4.1
grafana-kiosk: amd64 (latest binary grafana-kiosk.linux.amd64)
method: local

When using grafana-kiosk with the most recent version of grafana v6.4.1, with a local login method, it does not achieve successful login. Chrome ends up on the 'login/reset password' page (grafanarootURL/user/password/send-reset-email).

What I think is happening sequentially;

  • The 'email or username' field is skipped
  • The 'password' field is filled with something (probably the password?)
  • The 'Forgot your password?' is clicked

I looked briefly at the code and inspected the form, I'm guessing that the name change field of the 'email or username' field might have to do something with it. I think historically it was 'username' but now it is 'user'.

@jortkoopmans
Copy link
Contributor Author

Looking at it a bit longer, I'm not sure the 'username' field changes matter, since it does not seem used for selection.
I'm not going to be able to provide a PR for this, because I'm not a Go programmer and I'm confused on how I would need to build the local_login functions changes which are currently a requirement for building with 'make'. Basically I can't get any changes in local_login propagated into the binary...

@briangann briangann self-assigned this Oct 7, 2019
@briangann briangann added the bug Something isn't working label Oct 7, 2019
@briangann
Copy link
Collaborator

taking a look, i'll upgrade my kiosk and see what happens.

@jortkoopmans
Copy link
Contributor Author

jortkoopmans commented Oct 8, 2019

Ok I lied; I did manage to fix this for my setup. I'm not sure what caused the previously sent keys to fail, either something on the Grafana login page or Chromium, but this fixes it for me.
Note that I've followed the syntax of the examples (https://github.com/chromedp/examples/blob/master/keys/main.go) using the ` instead of ", but feel free to change that.

@briangann
Copy link
Collaborator

upgraded to 6.4.3 and i get this now, will provide a fix

briangann pushed a commit that referenced this issue Oct 17, 2019
…o changes in Grafana or chromedp. Aims to solve #7. (#8)
@briangann
Copy link
Collaborator

the merged PR didn't fix it for me, will sort it out quickly, my kiosk is broken :)

@briangann
Copy link
Collaborator

it actually did fix the problem, i was building the source from the wrong location

@zeppmg
Copy link

zeppmg commented Nov 4, 2019

hi,
i've been experiencing the same issue since i've updated grafana to v.6.4.3.
updated grafana-kiosk, problem still remains. i'm always redirected to the Reset password page.

@jortkoopmans
Copy link
Contributor Author

@zeppmg ; Did you compile the grafana-kiosk binary yourself? Because the binaries posted in the bin folder have not been updated....
@briangann ; The binaries posted there can be confusing. Ideally for binaries the 'release' feature of github can be leveraged.

@briangann
Copy link
Collaborator

my mistake! i will put in a new release with the fix

#14

@briangann briangann reopened this Nov 6, 2019
@zeppmg
Copy link

zeppmg commented Nov 6, 2019

@jortkoopmans no i didn't compile it myself, i updated with git pull.
Regards,

@zeppmg
Copy link

zeppmg commented Dec 2, 2019

Hi @briangann ,
Is there a planned date for the fix to be put online ? Still stuck here ...
Thanks in advance.
Regards,

@jortkoopmans
Copy link
Contributor Author

Best is to compile it yourself.
But if you trust me, you can find it attached (linux amd64).
issue7_grafana-kiosk.linux.amd64.zip

@zeppmg
Copy link

zeppmg commented Dec 2, 2019

Thanks for your answer + tip.
Regards,

@digerata
Copy link

digerata commented Dec 3, 2019

I hit this issue as well. Because there isn't a release, I'm trying to build this on the Raspberry Pi. I'm not sure the build instructions are complete. Running make I get:

Building grafana-kiosk
GOOS=darwin GOARCH=amd64 go build -o bin/grafana-kiosk.darwin pkg/cmd/grafana-kiosk/main.go
pkg/cmd/grafana-kiosk/main.go:10:2: cannot find package "github.com/grafana/grafana-kiosk/pkg/initialize" in any of:
	/usr/lib/go-1.11/src/github.com/grafana/grafana-kiosk/pkg/initialize (from $GOROOT)
	/home/pi/go/src/github.com/grafana/grafana-kiosk/pkg/initialize (from $GOPATH)
pkg/cmd/grafana-kiosk/main.go:11:2: cannot find package "github.com/grafana/grafana-kiosk/pkg/kiosk" in any of:
	/usr/lib/go-1.11/src/github.com/grafana/grafana-kiosk/pkg/kiosk (from $GOROOT)
	/home/pi/go/src/github.com/grafana/grafana-kiosk/pkg/kiosk (from $GOPATH)
make: *** [Makefile:9: dev] Error 1

@digerata
Copy link

digerata commented Dec 3, 2019

Ah! So building requires the source to be installed under /home/pi/go/src/github.com/grafana/. Move the project there and things work...

@briangann briangann added this to To do in grafana-kiosk Dec 20, 2019
@briangann
Copy link
Collaborator

The CircleCI build process has been updated to create release binaries (and branches)

You can find the latest here: https://github.com/grafana/grafana-kiosk/releases

If there's interest I can split the binaries out into separate downloadable files instead of (or in addition to) a giant zip/tar file with all builds inside.

@briangann
Copy link
Collaborator

Fixed by #17

@briangann briangann moved this from To do to Review in progress in grafana-kiosk Dec 20, 2019
@briangann
Copy link
Collaborator

If you have any issues with the releases let me know :)

grafana-kiosk automation moved this from Review in progress to Done Dec 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
grafana-kiosk
  
Done
Development

No branches or pull requests

4 participants