Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grafana 9 playList id vs uid, unable to find playlist. #80

Open
NissesSenap opened this issue Oct 4, 2022 · 3 comments
Open

grafana 9 playList id vs uid, unable to find playlist. #80

NissesSenap opened this issue Oct 4, 2022 · 3 comments
Labels
bug Something isn't working needs investigation no stalebot exempt from stale bot

Comments

@NissesSenap
Copy link

I currently don't hard-code the uid of my playLists, instead I rely on id to know which playlist I want to use.

After upgrading to grafana 9 this is no longer possible.
If I define

target:
    URL: http://xxx:3000/playlists/play/1

grafana kiosk will say it's unable to find the playlist.
I haven't looked at the code so far but I think it should be rather straight forward to add a translation function that if ID is specified automatically get the UID and use that one instead.

This change should be able to be backwards compatible.

@briangann briangann added bug Something isn't working needs investigation labels Oct 12, 2022
@briangann
Copy link
Collaborator

will take a look and see how to handle v8/v9 differences in playlist arguments. thanks!

@NissesSenap
Copy link
Author

@briangann I have created a PR that is a PoC that I currently use:
#90

The code is horrible and it currently depends on my fork of grafana-api-golang-client: grafana/grafana-api-golang-client#113

Using the grafana API is the only way that I have come up with to solve this issue.
Do you think a similar solution could be an option?

Of course with support for other login solutions, a big refactor and hopefully my grafana-api-golang-client getting merged ^^.
If you think this is a okay way forward then I can keep on working on it.

@NissesSenap
Copy link
Author

It looks like there is work ongoing on the grafana side grafana/grafana#56048.

@github-actions github-actions bot added the stale label Mar 7, 2023
@briangann briangann added no stalebot exempt from stale bot and removed stale labels Mar 7, 2023
@briangann briangann added this to To do in grafana-kiosk Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs investigation no stalebot exempt from stale bot
Projects
grafana-kiosk
  
To do
Development

No branches or pull requests

2 participants