Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make grafan-kiosk compatible with grafana 9 UID vs ID #90

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NissesSenap
Copy link

This is a PoC for #80 and far from ready to become merged.

This is a PoC and far from ready to become merged.
@CLAassistant
Copy link

CLAassistant commented Oct 13, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Edvin Norling seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@NissesSenap NissesSenap marked this pull request as draft October 13, 2022 07:09
@github-actions github-actions bot added the stale label Mar 7, 2023
@briangann briangann added no stalebot exempt from stale bot and removed stale labels Mar 7, 2023
@grafana grafana deleted a comment from github-actions bot Mar 7, 2023
@briangann
Copy link
Collaborator

i'm not having any issues running the kiosk with grafana 9.4.3, is it hanging somewhere, any logs?

@NissesSenap
Copy link
Author

NissesSenap commented Mar 11, 2023

So I literately left my job yesterday so I can't access those files any more.

But as I tried to explain in #80 this is the issue of not being able to define the id vs uid of the target play list.

I don't keep my grafana instances consistent through a database but rather through gitops. So when my grafana instances restarts due to kubernetes moving it around or what ever I will get assigned a new UID. And due to this it's unable to find my playlist.

So I need the old id functionality to be able to know what I should configure as target URL in kiosk since the ID is deterministic.
Another option is if we could add the functionality of looking for a playlist name instead of a specific uid/id.

I updated the PR subject to make this a bit more clear @briangann

@NissesSenap NissesSenap changed the title Make grafan-kiosk compatible with grafana 9 Make grafan-kiosk compatible with grafana 9 UID vs ID Mar 11, 2023
@briangann briangann self-requested a review November 29, 2023 14:25
@briangann briangann self-assigned this Nov 29, 2023
@briangann briangann added this to To do in grafana-kiosk Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no stalebot exempt from stale bot
Projects
grafana-kiosk
  
To do
Development

Successfully merging this pull request may close these issues.

None yet

3 participants