Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add the ability to set window-size #101

Merged
merged 1 commit into from
Mar 25, 2023
Merged

feat: add the ability to set window-size #101

merged 1 commit into from
Mar 25, 2023
+30 −16

Conversation

gaetanars
Copy link
Contributor

This is a proposal to pass window-size parameter to chromium (#29)
If this parameter is not set, no flag is set

@CLAassistant
Copy link

CLAassistant commented Mar 22, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@briangann briangann self-requested a review March 25, 2023 02:43
briangann
briangann approved these changes Mar 25, 2023
View reviewed changes
Copy link
Collaborator

@briangann briangann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks!

@briangann briangann merged commit 590321e into grafana:main Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briangann briangann briangann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gaetanars @CLAassistant @briangann