Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix autofit logic #103

Merged
merged 1 commit into from
Mar 26, 2023
Merged

fix autofit logic #103

merged 1 commit into from
Mar 26, 2023

Conversation

briangann
Copy link
Collaborator

@briangann briangann commented Mar 25, 2023

Grafana doesn't parse autofitpanels= correctly, it only expects autofitpanels with no equals or value.

this detects if there are params set, and appends as necessary.

Along with WindowSize and AutoFitPanels, the kiosk works on smaller displays like a 7" touchscreen (1024x600 resolution) and scales the panels as intended.

@briangann briangann marked this pull request as ready for review March 25, 2023 13:45
@codeclimate
Copy link

codeclimate bot commented Mar 25, 2023

Code Climate has analyzed commit e77f44c and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 3.9% (0.5% change).

View more on Code Climate.

@briangann briangann merged commit a76368f into main Mar 26, 2023
@briangann briangann deleted the 20230325_fix_autofit branch March 26, 2023 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant