Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AzureAD Auto-Login Local Override #107

Merged
merged 5 commits into from
Nov 29, 2023

Conversation

friedpope
Copy link
Contributor

This is for Issue #106. I think it's ready to merge, the changes are pretty simple.

@CLAassistant
Copy link

CLAassistant commented Apr 19, 2023

CLA assistant check
All committers have signed the CLA.

@friedpope
Copy link
Contributor Author

I'm not sure what that last codeclimate issue is on line 1, I'm happy to fix it if anyone can add some more detail as to what's wrong.

@briangann
Copy link
Collaborator

it's a "gofmt" issue, just formatting that can be fixed post-merge.

Copy link
Collaborator

@briangann briangann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are there docs to be added for this option?

@friedpope
Copy link
Contributor Author

are there docs to be added for this option?

Sure, I'll work on an update to README.md tomorrow.

@friedpope friedpope requested a review from briangann June 5, 2023 22:15
…login to use the 'User avatar' instead of the nav bar since that's changed in the new Grafana update
@briangann
Copy link
Collaborator

briangann commented Jul 21, 2023

can you run mage build:format to update the source files to pass the "gofmt" check? if not, i can run it post-merge, looks like this is ready to release!

@github-actions github-actions bot added the stale label Oct 19, 2023
@briangann briangann added no stalebot exempt from stale bot and removed stale labels Oct 19, 2023
@grafana grafana deleted a comment from github-actions bot Nov 29, 2023
@briangann briangann merged commit d43b34a into grafana:main Nov 29, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no stalebot exempt from stale bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants