Add an option to ignore certificate errors #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes grafana#25 The flag `-ignore-certificate-errors` has been added which will ignore issues with SSL/TLS certificates (such as self-signed and expired certs). This will only work on anonymous and local login types as invalid certificates for grafana.com should never be ignored.
|
Testing instructions added with a sample dashboard. |
Closed
|
Hello, is there any update on this PR? 😊 Just wondering if I need to do some work around deploying my own build for now or if I can use the official build from this repo in my project. Thanks. |
|
testing this out now, sorry for the long delay! |
|
Awesome, many thanks @briangann 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25
The flag
-ignore-certificate-errorshas been added which will ignoreissues with SSL/TLS certificates (such as self-signed and expired
certs).
This will only work on anonymous and local login types as invalid
certificates for grafana.com should never be ignored.
Testing instructions
Run
maketo generate the binariesRun the following command to launch a sample dashboard with a bad SSL certificate
Run the following command to launch with
--ignore-certificate-errorsExpected results
The build will complete
You should see a warning about your connection not being private.
You should see the dashboard be displayed.