Telegraf/Influx converter #1
Conversation
| } | ||
|
|
||
| // FrameWrapper is a wrapper over data.Frame. | ||
| type FrameWrapper interface { |
There was a problem hiding this comment.
fine for now... but maybe we should add "key" as a standard frame property 🤔
There was a problem hiding this comment.
hmm, maybe not - because the key here used mostly to construct a channel name to publish data into, maybe better try to keep live specifics separate from general data frame logic as long as possible?
| frameWrappers, err := converter.Convert(testData) | ||
| require.NoError(t, err) | ||
| require.Len(t, frameWrappers, 1) | ||
|
|
There was a problem hiding this comment.
consider adding a "golden" test -- I find these super userful for understanding input vs output -- and would love your help/advice making the core interface better :)
See:
https://github.com/grafana/grafana/blob/master/pkg/tsdb/influxdb/flux/executor_test.go#L70
Or:
https://github.com/grafana/oas-datasource/blob/fa755294643e56371afe326850aaf76eb0bb6f88/pkg/server/test/server_test.go#L69
| ) | ||
|
|
||
| // FieldTypeFor returns a concrete type for a given interface or unknown if not known | ||
| func FieldTypeFor(t interface{}) data.FieldType { |
Added converter from telegraf/influx format to Grafana Data Frames. This converter generates one frame for each input metric name and time combination.
Not sure about naming - maybe it's better to call package
influxinstead oftelegraf(since input is ininfluxformat, but it contains metrics which aretelegraf.Metric).Benchmark: