This repository has been archived by the owner on Mar 8, 2022. It is now read-only.
Check field type before appending #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ryantxu
commented
Jun 8, 2021
| @@ -186,14 +214,6 @@ func TestConverter_Convert_NumFrameFields_LabelsColumn(t *testing.T) { | |||
| require.JSONEqf(t, string(frameJSON), string(want), "not matched with golden file") | |||
| } | |||
|
|
|||
| func TestConverter_Convert_LabelsColumn_MixedNumberTypes_Panics(t *testing.T) { | |||
There was a problem hiding this comment.
this tested explicitly that chaning the type panics -- silently replacing with null is not great, but panic seems pretty bad for user enter data
ryantxu
commented
Jun 9, 2021
| s.fields[index].Append(v) | ||
| field := s.fields[index] | ||
| if ft != field.Type() { | ||
| fmt.Printf("error appending value of type: %v as %v // %v\n", field.Type(), ft, v) |
There was a problem hiding this comment.
@FZambia what is the best logging option here?
There was a problem hiding this comment.
Maybe pass logger from the outside?
|
not necessary... this was moved to grafana core |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the input for a field changes we currently panic -- we should do something better than that