Skip to content

Commit

Permalink
Add name to reconciler logs.
Browse files Browse the repository at this point in the history
  • Loading branch information
smuda committed May 4, 2023
1 parent 8ec3fa0 commit 070d009
Show file tree
Hide file tree
Showing 10 changed files with 14 additions and 14 deletions.
4 changes: 2 additions & 2 deletions controllers/dashboard_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ type GrafanaDashboardReconciler struct {
//+kubebuilder:rbac:groups=grafana.integreatly.org,resources=grafanadashboards/finalizers,verbs=update

func (r *GrafanaDashboardReconciler) syncDashboards(ctx context.Context) (ctrl.Result, error) {
syncLog := log.FromContext(ctx)
syncLog := log.FromContext(ctx).WithName("GrafanaDashboardReconciler")
dashboardsSynced := 0

// get all grafana instances
Expand Down Expand Up @@ -148,7 +148,7 @@ func getDashboardsToDelete(allDashboards *v1beta1.GrafanaDashboardList, grafanas
}

func (r *GrafanaDashboardReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
controllerLog := log.FromContext(ctx)
controllerLog := log.FromContext(ctx).WithName("GrafanaDashboardReconciler")
r.Log = controllerLog

// periodic sync reconcile
Expand Down
4 changes: 2 additions & 2 deletions controllers/datasource_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ type GrafanaDatasourceReconciler struct {
//+kubebuilder:rbac:groups=grafana.integreatly.org,resources=grafanadatasources/finalizers,verbs=update

func (r *GrafanaDatasourceReconciler) syncDatasources(ctx context.Context) (ctrl.Result, error) {
syncLog := log.FromContext(ctx)
syncLog := log.FromContext(ctx).WithName("GrafanaDatasourceReconciler")
datasourcesSynced := 0

// get all grafana instances
Expand Down Expand Up @@ -139,7 +139,7 @@ func (r *GrafanaDatasourceReconciler) syncDatasources(ctx context.Context) (ctrl
}

func (r *GrafanaDatasourceReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
controllerLog := log.FromContext(ctx)
controllerLog := log.FromContext(ctx).WithName("GrafanaDatasourceReconciler")
r.Log = controllerLog

// periodic sync reconcile
Expand Down
2 changes: 1 addition & 1 deletion controllers/grafana_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ type GrafanaReconciler struct {
//+kubebuilder:rbac:groups=networking.k8s.io,resources=ingresses,verbs=get;list;watch;create;update;patch;delete

func (r *GrafanaReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
controllerLog := log.FromContext(ctx)
controllerLog := log.FromContext(ctx).WithName("GrafanaReconciler")

grafana := &grafanav1beta1.Grafana{}
err := r.Get(ctx, req.NamespacedName, grafana)
Expand Down
4 changes: 2 additions & 2 deletions controllers/grafanafolder_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ type GrafanaFolderReconciler struct {
//+kubebuilder:rbac:groups=grafana.integreatly.org,resources=grafanafolders/finalizers,verbs=update

func (r *GrafanaFolderReconciler) syncFolders(ctx context.Context) (ctrl.Result, error) {
syncLog := log.FromContext(ctx)
syncLog := log.FromContext(ctx).WithName("GrafanaFolderReconciler")
foldersSynced := 0

// get all grafana instances
Expand Down Expand Up @@ -141,7 +141,7 @@ func (r *GrafanaFolderReconciler) syncFolders(ctx context.Context) (ctrl.Result,
// For more details, check Reconcile and its Result here:
// - https://pkg.go.dev/sigs.k8s.io/controller-runtime@v0.9.2/pkg/reconcile
func (r *GrafanaFolderReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
controllerLog := log.FromContext(ctx)
controllerLog := log.FromContext(ctx).WithName("GrafanaFolderReconciler")
r.Log = controllerLog

// periodic sync reconcile
Expand Down
2 changes: 1 addition & 1 deletion controllers/reconcilers/grafana/complete_reconciler.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ func NewCompleteReconciler() reconcilers.OperatorGrafanaReconciler {
}

func (r *CompleteReconciler) Reconcile(ctx context.Context, cr *v1beta1.Grafana, status *v1beta1.GrafanaStatus, vars *v1beta1.OperatorReconcileVars, scheme *runtime.Scheme) (v1beta1.OperatorStageStatus, error) {
logger := log.FromContext(ctx)
logger := log.FromContext(ctx).WithName("CompleteReconciler")
logger.Info("grafana installation complete")
return v1beta1.OperatorStageResultSuccess, nil
}
2 changes: 1 addition & 1 deletion controllers/reconcilers/grafana/deployment_reconciler.go
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ func NewDeploymentReconciler(client client.Client, isOpenShift bool) reconcilers
}

func (r *DeploymentReconciler) Reconcile(ctx context.Context, cr *v1beta1.Grafana, status *v1beta1.GrafanaStatus, vars *v1beta1.OperatorReconcileVars, scheme *runtime.Scheme) (v1beta1.OperatorStageStatus, error) {
logger := log.FromContext(ctx)
logger := log.FromContext(ctx).WithName("DeploymentReconciler")

openshiftPlatform := r.isOpenShift
logger.Info("reconciling deployment", "openshift", openshiftPlatform)
Expand Down
2 changes: 1 addition & 1 deletion controllers/reconcilers/grafana/ingress_reconciler.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ func NewIngressReconciler(client client.Client, isOpenShift bool) reconcilers.Op
}

func (r *IngressReconciler) Reconcile(ctx context.Context, cr *v1beta1.Grafana, status *v1beta1.GrafanaStatus, vars *v1beta1.OperatorReconcileVars, scheme *runtime.Scheme) (v1beta1.OperatorStageStatus, error) {
logger := log.FromContext(ctx)
logger := log.FromContext(ctx).WithName("IngressReconciler")

if r.isOpenShift {
logger.Info("reconciling route", "platform", "openshift")
Expand Down
2 changes: 1 addition & 1 deletion controllers/reconcilers/grafana/plugins_reconciler.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ func NewPluginsReconciler(client client.Client) reconcilers.OperatorGrafanaRecon
}

func (r *PluginsReconciler) Reconcile(ctx context.Context, cr *v1beta1.Grafana, status *v1beta1.GrafanaStatus, vars *v1beta1.OperatorReconcileVars, scheme *runtime.Scheme) (v1beta1.OperatorStageStatus, error) {
logger := log.FromContext(ctx)
logger := log.FromContext(ctx).WithName("PluginsReconciler")

plugins := model.GetPluginsConfigMap(cr, scheme)
selector := client.ObjectKey{
Expand Down
2 changes: 1 addition & 1 deletion controllers/reconcilers/grafana/pvc_reconciler.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ func NewPvcReconciler(client client.Client) reconcilers.OperatorGrafanaReconcile
}

func (r *PvcReconciler) Reconcile(ctx context.Context, cr *v1beta1.Grafana, status *v1beta1.GrafanaStatus, vars *v1beta1.OperatorReconcileVars, scheme *runtime.Scheme) (v1beta1.OperatorStageStatus, error) {
logger := log.FromContext(ctx)
logger := log.FromContext(ctx).WithName("PvcReconciler")

if cr.Spec.PersistentVolumeClaim == nil {
logger.Info("skip creating persistent volume claim")
Expand Down
4 changes: 2 additions & 2 deletions main.go
Original file line number Diff line number Diff line change
Expand Up @@ -153,15 +153,15 @@ func main() {
if err = (&controllers.GrafanaDashboardReconciler{
Client: mgr.GetClient(),
Scheme: mgr.GetScheme(),
Log: ctrl.Log,
Log: ctrl.Log.WithName("DashboardReconciler"),
}).SetupWithManager(mgr, ctx); err != nil {
setupLog.Error(err, "unable to create controller", "controller", "GrafanaDashboard")
os.Exit(1)
}
if err = (&controllers.GrafanaDatasourceReconciler{
Client: mgr.GetClient(),
Scheme: mgr.GetScheme(),
Log: ctrl.Log,
Log: ctrl.Log.WithName("DatasourceReconciler"),
}).SetupWithManager(mgr, ctx); err != nil {
setupLog.Error(err, "unable to create controller", "controller", "GrafanaDatasource")
os.Exit(1)
Expand Down

0 comments on commit 070d009

Please sign in to comment.