[Bug] Duplicate labels because of unsafe use of merge

[kuznero]

Describe the bug

Templates produce duplicate labels because of unsafe use of merge.

Version

v5.4.2

To Reproduce

Run helm template -f values.yaml . from the root of the chart folder and notice repetitive labels in deployment resource.

Expected behavior

Should have no duplicates in labels.

Suspect component/Location where the bug might be occurring

In rbac.yaml:

  {{- with (merge $.Values.additionalLabels (include "grafana-operator.labels" $ | fromYaml)) }}
  labels:
    {{- toYaml . | nindent 4 }}
  {{- end }}

The fix is to make a deep copy of .Values.additionalLabels before calling merge:

  {{- $additionalLabelsCopy := deepCopy $.Values.additionalLabels }}
  {{- with (merge $additionalLabelsCopy (include "grafana-operator.labels" $ | fromYaml)) }}
  labels:
    {{- toYaml . | nindent 4 }}
  {{- end }}

Runtime (please complete the following information):

• OS: Linux (Debian 12)
• Grafana Operator Version [e.g. v5.4.2]
• Environment: Kubernetes
• Deployment type: deployed
• Other: deploying using fluxcd

[weisdd]

I believe it was first reported in #1298 and fixed in #1299, which will be part of the upcoming release. So, I'm going to close the issue.
Though, thanks for reporting!