helm chart: align labeling of rbac resources #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weisdd
previously requested changes
Nov 7, 2023
|
Yeah sadly I wasn't on a dev machine when I saw the error pop up so I wasn't able to validate that my change would fix it. I'll get round to checking the suggested changes once I have a machine with helm functioning. |
|
@siegenthalerroger do you have time to look at this some time this week? |
Co-authored-by: Igor Beliakov <46579601+weisdd@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully fixes: #1298
This PR aligns the labels introduced by #1271 to the same code style as the other labels. I hope that this results in the above issue being fixed.