[Bug] Default values in Helm chart are broken in v5.5.0

[yafanasiev]

Describe the bug

Helm chart installation fails

Error: YAML parse error on grafana-operator/templates/deployment.yaml: error converting YAML to JSON: yaml: line 36: did not find expected '-' indicator
helm.go:84: [debug] error converting YAML to JSON: yaml: line 36: did not find expected '-' indicator

Version
v5.5.0

To Reproduce

1. Clone grafana-operator repository (or pull the chart using helm pull)
2. Run helm template .
3. See the error.

Expected behavior
Chart is templated using default values.

Suspect component/Location where the bug might be occurring
It was introduced in 3166d43. In this PR a duplicate env root key in values.yaml was introduced.

Runtime (please complete the following information):

• OS: macOS 14.0 (23A344)
• Grafana Operator Version v5.5.0
• Helm version.BuildInfo{Version:"v3.13.2", GitCommit:"2a2fb3b98829f1e0be6fb18af2f6599e0f4e8243", GitTreeState:"clean", GoVersion:"go1.21.4"}

Additional context
Working workaround:

env:
  grafanaImage: ~

[yafanasiev]

Maybe it would be worth introducing some kind of automated checks for linting Helm chart? I could help with that.

[NissesSenap]

@yafanasiev yes I was thinking about that as well. Sadly I haven't had the time. If you do I would love a separate PR for it.
I will fix a new release today after I looked at the PR

[NissesSenap]

@yafanasiev yes I was thinking about a hem template check as well. Sadly I haven't had the time. If you do I would love a separate PR for it.

[weisdd]

@yafanasiev FYI: helm lint and helm template were added in #1318 by @NissesSenap, so we should not hit the same issue ever again :)

[yafanasiev]

@weisdd thanks a lot!