Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Grafana Operator is not able to read ConfigMaps with the current RBAC implementation #366

Closed
Cellebyte opened this issue Mar 11, 2021 · 3 comments · Fixed by #368
Closed

[Bug] Grafana Operator is not able to read ConfigMaps with the current RBAC implementation #366

Cellebyte opened this issue Mar 11, 2021 · 3 comments · Fixed by #368
Labels
bug Something isn't working good first issue Good for newcomers triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@Cellebyte
Copy link
Contributor

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Create a GrafanaDashboard with configmap ref.
  2. Create a Configmap which holds a Dashboard or Jsonnet Lib
  3. Look at the logs.

Expected behavior
The rbac in the deploy should be fixed so that ConfigMaps are able to be read by the operator.
Currently some documented things are not working with the simple deployment.
@Cellebyte Cellebyte added bug Something isn't working needs triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 11, 2021
@pb82
Copy link
Collaborator

pb82 commented Mar 11, 2021

Was the ConfigMap in the same namespace as the Operator?

@Cellebyte
Copy link
Contributor Author

Cellebyte commented Mar 12, 2021 •
edited
Loading

@pb82 the operator was deployed cluster wide with the rbac from your repo.

@pb82
Copy link
Collaborator

pb82 commented Mar 16, 2021

Looks like permissions for configmaps need to be added here: https://github.com/integr8ly/grafana-operator/blob/master/deploy/cluster_roles/cluster_role_grafana_operator.yaml

@pb82 pb82 added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 16, 2021
@HVBE HVBE added the good first issue Good for newcomers label Mar 16, 2021
@HVBE HVBE mentioned this issue Mar 16, 2021
Merged
7 tasks
@HVBE HVBE linked a pull request Mar 16, 2021 that will close this issue
add configmaps to cluster_role permissions #368
Merged
7 tasks
@HVBE HVBE closed this as completed in #368 Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add configmaps to cluster_role permissions HVBE/grafana-operator
3 participants
@pb82 @Cellebyte @HVBE