Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add configmaps to cluster_role permissions #368

Merged
merged 1 commit into from
Apr 6, 2021
Merged

Conversation

HVBE
Copy link
Collaborator

@HVBE HVBE commented Mar 16, 2021

Description

Add configmaps to cluster permissions for the operator

Relevant issues/tickets

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • This change requires a documentation update
  • I have added tests that prove my fix is effective or that my feature works
  • I have added a test case that will be used to verify my changes
  • Verified independently on a cluster by reviewer

Verification steps

  • Create a GrafanaDashboard with configmap ref.
  • Create a Configmap which holds a Dashboard or Jsonnet Lib
  • Ensure the operator has created a valid dashboard with the configmap contents

@HVBE
Copy link
Collaborator Author

HVBE commented Mar 16, 2021

@Cellebyte mind verifying that this resolves the issue you described in #366 ? thanks 👍

@HVBE HVBE added this to In progress in Grafana Operator (Kanban) via automation Mar 16, 2021
@HVBE HVBE moved this from In progress to Review in progress in Grafana Operator (Kanban) Mar 16, 2021
@HVBE
Copy link
Collaborator Author

HVBE commented Mar 23, 2021

@Cellebyte have you got the chance to verify that this works for you?

Grafana Operator (Kanban) automation moved this from Review in progress to Reviewer approved Apr 6, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pb82

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pb82
Copy link
Collaborator

pb82 commented Apr 6, 2021

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Apr 6, 2021

@HubertStefanski: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/format 4f0e924 link /test format
ci/prow/images 4f0e924 link /test images
ci/prow/unit 4f0e924 link /test unit
ci/prow/e2e 4f0e924 link /test e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@HVBE HVBE merged commit 1f9d32c into grafana:master Apr 6, 2021
Grafana Operator (Kanban) automation moved this from Reviewer approved to Done Apr 6, 2021
@HVBE
Copy link
Collaborator Author

HVBE commented Apr 6, 2021

overriding CI, still broken ....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

[Bug] Grafana Operator is not able to read ConfigMaps with the current RBAC implementation
3 participants