Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] missing patch verb on events in clusterrole #630

Closed
davidkarlsen opened this issue Nov 29, 2021 · 1 comment
Closed

[Bug] missing patch verb on events in clusterrole #630

davidkarlsen opened this issue Nov 29, 2021 · 1 comment
Labels
bug Something isn't working triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@davidkarlsen
Copy link
Contributor

Describe the bug
the operator cannot create events in namespaces containing dashboards to import

Version
v4.0.2

To Reproduce
Steps to reproduce the behavior:

  1. Add --scan-all in order to allow import of dashboards in other namespaces than where the operator runs
  2. add dashboard via discovery
  3. see log of operator

Expected behavior
A clear and concise description of what you expected to happen.

Suspect component/Location where the bug might be occuring
Please provide this if you know where this bug might occur otherwise leave as unknown

Screenshots

grafana-operator-controller-manager-755b894649-m6xjf manager E1129 11:04:12.090501       1 event.go:264] Server rejected event '&v1.Event{TypeMeta:v1.TypeMeta{Kind:"", APIVersion:""}, ObjectMeta:v1.ObjectMeta{Name:"timedmetrics.16bbff7f2040600d", GenerateName:"", Namespace:"cen-test", SelfLink:"", UID:"", ResourceVersion:"1644188560", Generation:0, CreationTimestamp:v1.Time{Time:time.Time{wall:0x0, ext:0, loc:(*time.Location)(nil)}}, DeletionTimestamp:(*v1.Time)(nil), DeletionGracePeriodSeconds:(*int64)(nil), Labels:map[string]string(nil), Annotations:map[string]string(nil), OwnerReferences:[]v1.OwnerReference(nil), Finalizers:[]string(nil), ClusterName:"", ManagedFields:[]v1.ManagedFieldsEntry(nil)}, InvolvedObject:v1.ObjectReference{Kind:"GrafanaDashboard", Namespace:"cen-test", Name:"timedmetrics", UID:"3d55a338-34eb-4463-8139-e8de758f709c", APIVersion:"integreatly.org/v1alpha1", ResourceVersion:"1581415497", FieldPath:""}, Reason:"ProcessingError", Message:"invalid character '.' after object key:value pair", Source:v1.EventSource{Component:"controller_grafanadashboard", Host:""}, FirstTimestamp:v1.Time{Time:time.Time{wall:0x0, ext:63773780610, loc:(*time.Location)(0x2589780)}}, LastTimestamp:v1.Time{Time:time.Time{wall:0xc0614acb0538e4bd, ext:89579741228, loc:(*time.Location)(0x2589780)}}, Count:5, Type:"Warning", EventTime:v1.MicroTime{Time:time.Time{wall:0x0, ext:0, loc:(*time.Location)(nil)}}, Series:(*v1.EventSeries)(nil), Action:"", Related:(*v1.ObjectReference)(nil), ReportingController:"", ReportingInstance:""}': 'events "timedmetrics.16bbff7f2040600d" is forbidden: User "system:serviceaccount:grafana-operator:grafana-operator-controller-manager" cannot patch resource "events" in API group "" in the namespace "cen-test"' (will not retry!)

Runtime (please complete the following information):

  • OS: not relevant
  • Grafana Operator Version: v4.0.2
  • Environment: openshift 4.8.x
  • Deployment type: OLM via operatorhub
  • Other: N/A

Additional context
Add any other context about the problem here.

- apiGroups:
  - ""
  resources:
  - events
  verbs:
  - create
  - get
  - list
  - watch

create but no patch

@davidkarlsen davidkarlsen added bug Something isn't working needs triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 29, 2021
NissesSenap pushed a commit to NissesSenap/grafana-operator that referenced this issue Nov 30, 2021
This way --scan-all don't have to add any custom clusterroles.
Solves grafana#630
NissesSenap pushed a commit to NissesSenap/grafana-operator that referenced this issue Nov 30, 2021
This way --scan-all don't have to add any custom clusterroles.
Solves grafana#630
@pb82 pb82 added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 30, 2021
@NissesSenap
Copy link
Collaborator

NissesSenap commented Nov 30, 2021

This will be released in v4.1.0
Thanks for creating the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

3 participants