-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dashboard:jsonnet): support jsonnet external variables for GrafanaDashboard #1130
feat(dashboard:jsonnet): support jsonnet external variables for GrafanaDashboard #1130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks for contributing @olejeglejeg! just one nitpick, other than that we're good to merge :)
Co-authored-by: Hubert Stefanski <35736504+HubertStefanski@users.noreply.github.com>
@HubertStefanski I committed your suggestion. Can you please review again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM approved! thanks for contributing @olejeglejeg !
Solves #904