Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard from configmap #1143

Merged
merged 4 commits into from
Jul 11, 2023
Merged

Dashboard from configmap #1143

merged 4 commits into from
Jul 11, 2023

Conversation

pb82
Copy link
Collaborator

@pb82 pb82 commented Jul 5, 2023 •
edited
Loading

Basic implementation of the dashboard from config map feature similar to v4. A few questions:

  • The Kube ConfigMapKeySelector has an optional property. It is expected that clients do not fail when the config map does not exist. However, in the Grafana Operator we currently log an error in that case. Is that acceptable? What other behavior would be more suitable?
  • The Operator will not know when the Config Map gets updated. Users have to rely on the resync period to catch changes in the config map. Listening to config map changes is possible, but then we would have to filter out the ones that are linked to dashboard CRs. Is that worth doing?

@pb82 pb82 force-pushed the dashboard-from-configmap branch from 4cddac7 to ff72a3e Compare July 5, 2023 10:07
@pb82 pb82 force-pushed the dashboard-from-configmap branch from ff72a3e to 07fe64d Compare July 5, 2023 10:17
NissesSenap
NissesSenap approved these changes Jul 11, 2023
View reviewed changes
Copy link
Collaborator

@NissesSenap NissesSenap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pb82 pb82 merged commit d1b9534 into grafana:master Jul 11, 2023
9 checks passed
@pb82 pb82 deleted the dashboard-from-configmap branch July 11, 2023 12:15
@NissesSenap NissesSenap mentioned this pull request Jul 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NissesSenap NissesSenap NissesSenap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pb82 @NissesSenap