Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use dashboard CR namespace as a default folder title #1147

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

weisdd
Copy link
Collaborator

@weisdd weisdd commented Jul 6, 2023

This PR implements the behaviour change suggested in #1146.

NOTE: I my test lab, it worked fine. The only edge case I found was with the General folder (not returned in API, need to hardcode it). Though, please, make sure everything works as expected for you as well.

Fixes: #1146

@weisdd weisdd self-assigned this Jul 6, 2023
@weisdd weisdd requested review from pb82, NissesSenap and HVBE July 6, 2023 13:22
Copy link
Collaborator

@HVBE HVBE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified locally, looks to be working as intended!

@HVBE HVBE merged commit e092666 into master Jul 11, 2023
9 checks passed
@HVBE HVBE deleted the feat/dashboard-default-folder-title branch July 11, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GrafanaDashboard] Use CR's namespace as a default folder name
2 participants