feat: [helm] set additional labels #1154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set extra pod labels, other than selector labels. This is useful to add extra information to the operator pod. Signed-off-by: Ricardo Ribeiro <j.ribeiro.fafe@gmail.com>
|
Would it be reasonable to add a set of labels that can be applied everywhere, not just pods?
What do you think @jrRibeiro |
jrRibeiro
changed the title
This allows us to set extra labels, which is useful to add extra information to resources. Signed-off-by: Ricardo Ribeiro <j.ribeiro.fafe@gmail.com>
Yes, I agree! I moved from using specific pod labels to additional labels that are added to all resources, pods included. |
HVBE
reviewed
Jul 11, 2023
NissesSenap
approved these changes
Jul 11, 2023
|
LGTM, thanks for your contribution @jrRibeiro |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to set extra labels, which is useful to add extra information to resources.