Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump controller-gen to v0.12.0 #1159

Merged
merged 5 commits into from
Jul 24, 2023
Merged

Conversation

rodrigc
Copy link
Contributor

@rodrigc rodrigc commented Jul 11, 2023

Bump controller-gen to v.0.12.0

@rodrigc rodrigc changed the title Bump controller v0.12.0 Bump controller-gen to v0.12.0 Jul 11, 2023
@NissesSenap
Copy link
Collaborator

This we need to think a bit about. Don't know what have changed between the different versions.
Is there any specific reason you want to do it? Other than it's great to use a newer version :)

@rodrigc
Copy link
Contributor Author

rodrigc commented Jul 13, 2023

This change looks safe to merge.
Looking at: https://github.com/kubernetes-sigs/controller-tools/releases/

The changes in v0.12.0 are mostly dependency updates, and safe.
The change in v0.11.4 to remove creationTimestamp from generated files is a good one to take.

@pb82
Copy link
Collaborator

pb82 commented Jul 24, 2023

I don't see anything particularly worrying in the changelog since v0.10.0. The Kubernetes libraries are bumped a few times, but even v0.10.0 is using a version that's ahead of our minimum requirement.

@pb82 pb82 merged commit 5c5f894 into grafana:master Jul 24, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants