feat: allow replacement pattern in data sources #1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pb82
force-pushed
the
datasource-vars-partial
branch
2 times, most recently
from
b7f234f
to
d8f5917
Compare
pb82
force-pushed
the
datasource-vars-partial
branch
from
d8f5917
to
f053fae
Compare
HVBE
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR extends the existing functionality to inject values from Secrets into data sources. It allows replacement patterns (e.g.
Bearer ${TOKEN}) instead of overwriting whatever is there in the first place.Why
Injecting bearer tokens is a typical use case for data sources. However this was not properly supported until now. The value of a bearer token starts with
Bearerfollowed by the token. The existing mechanism replaced the whole value, including theBearerpart. You would have to includeBearerin the secret, but often you don't create or manage those secrets.How
Bevor overwriting the value found at the given path, we fetch it and apply the replacement.