Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add back subresource on OCP for custom hostname #1207

Merged
merged 3 commits into from
Aug 22, 2023

Conversation

davidkarlsen
Copy link
Contributor

Fix for #1197 - add RBAC permission to route sub-resource on OCP.

Signed-off-by: David J. M. Karlsen <david.johan.macdonald.karlsen@dnb.no>
@davidkarlsen
Copy link
Contributor Author

davidkarlsen commented Aug 21, 2023

There are also resources under the deploy directory - both for the kustomize overlays and the chart - are these manually maintained? I could not find anything suitable in the Makefile

@NissesSenap
Copy link
Collaborator

@davidkarlsen since the kustomize rbac differ between the different deployments modes, I haven't solved any autogenration of the RBAC rules. Same thing goes with the helm chart.

So sadly it's manually that is the way to go.
Could you take a look at that as well?
Other than that, I think it loos good.

Signed-off-by: David J. M. Karlsen <david.johan.macdonald.karlsen@dnb.no>
@davidkarlsen davidkarlsen marked this pull request as ready for review August 22, 2023 08:52
@davidkarlsen
Copy link
Contributor Author

@NissesSenap I think we're good to go

@NissesSenap NissesSenap enabled auto-merge (squash) August 22, 2023 08:58
@NissesSenap NissesSenap merged commit c980c4c into grafana:master Aug 22, 2023
9 checks passed
@davidkarlsen davidkarlsen deleted the feature/fix-rbac branch August 22, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants