grafanadatasource make values required #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow the grafana datasource http api with values that are required.
NissesSenap
force-pushed
the
dashboard_access
branch
from
d501d66
to
bf8349b
Compare
NissesSenap
commented
Sep 10, 2023
| @@ -28,7 +28,7 @@ func TestGrafanaDatasources_expandVariables(t *testing.T) { | |||
| }, | |||
| }, | |||
| }, | |||
| out: []byte("{\"name\":\"prometheus\",\"user\":\"root\"}"), | |||
| out: []byte("{\"name\":\"prometheus\",\"type\":\"\",\"url\":\"\",\"access\":\"\",\"user\":\"root\"}"), | |||
There was a problem hiding this comment.
Since the new values are required, the tests needed updating
HVBE
approved these changes
Sep 11, 2023
rlanore
added a commit
to rlanore/aws-observability-accelerator
that referenced
this pull request
Dec 7, 2023
elamaran11
pushed a commit
to aws-observability/aws-observability-accelerator
that referenced
this pull request
Dec 18, 2023
url mandatory for datasource since opeator version > 5.4.0 See: grafana/grafana-operator#1235
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow the grafana datasource http api with values that are required. This way we can remove some logic in code and make it easier for our users.
fixes #1035