Make operator exportable by removing grafonnet-lib git submodule #1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaehnri
changed the title
|
@jaehnri this looks good, let's just fix the lint issues (we can exclude the directory) and then we can merge this. |
|
@pb82, can you retrigger the tests, please? They should pass now. |
|
@jaehnri this test is failing now: |
jaehnri
force-pushed
the
fix-grafonnet-lib
branch
from
e7ca08e
to
50db118
Compare
|
@jaehnri it's passing now, must have been a fluke. Anyway, I'll try to get this merged today, thanks! |
Signed-off-by: João Henri <joao.rocha@suse.com>
Signed-off-by: João Henri <joao.henri@suse.com>
Signed-off-by: João Henri <joao.rocha@suse.com>
jaehnri
force-pushed
the
fix-grafonnet-lib
branch
from
8778b12
to
6fb4b0d
Compare
pb82
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1279
This PR removes the
grafonnet-libgit submodule and appends the entire repo as part of thegrafana-operator. Although it is not the most elegant solution, it makes this operator exportable.I'm glad to work on a better alternative if it exists.