fix: reintroduce-support-for-proxy #1286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HVBE
approved these changes
Oct 23, 2023
|
I tried this patch just now and it seemed to work fine on my restricted network environment. 👍 |
|
@weisdd should we add some docs around this to make it easy for people to find. As mentioned in #1274 (comment) it's currently not possible to add env variable to the grafana-operator helm chart. |
Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 39.2.2 to 39.2.3. - [Release notes](https://github.com/tj-actions/changed-files/releases) - [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md) - [Commits](tj-actions/changed-files@408093d...95690f9) --- updated-dependencies: - dependency-name: tj-actions/changed-files dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
pb82
force-pushed
the
fix/reintroduce-support-for-proxy
branch
from
2417fdd
to
d8ad7fa
Compare
NissesSenap
approved these changes
Oct 31, 2023
|
@NissesSenap sorry for the delay, I've just added support for envs. |
NissesSenap
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v4 of the operator had support for proxy config through env variables, which got lost when we introduced a custom transport.
This PR should bring it back by reusing the default http transport while preserving the customized settings.
NOTE: the proxy setting affects not only dashboard controller, but Grafana API as well, which might be useful when a Grafana instance cannot be reached directly, though makes configuration more complex as users will have to specify service/pod IP range in
NO_PROXY.Fixes: #1274