Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(proxy): don't use proxy for internal Grafana instances #1300

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

weisdd
Copy link
Collaborator

@weisdd weisdd commented Nov 7, 2023

As highlighted in #1295, it's not always easy to properly set NO_PROXY env to make sure requests to internal Grafana instances are not proxied.
Seems like it would make the most sense if we respect proxy settings only for external Grafana instances and for URL-based dashboards. Thus the PR.

Fixes: #1295

@HVBE HVBE merged commit dddafba into master Nov 8, 2023
9 checks passed
@HVBE HVBE deleted the fix/do-not-use-proxy-for-grafana-api branch November 8, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Setting a proxy can break the reconciler
2 participants