Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GrafanaFolder example syntax #1359

Merged
merged 1 commit into from Dec 22, 2023
Merged

Update GrafanaFolder example syntax #1359

merged 1 commit into from Dec 22, 2023

Conversation

johankok
Copy link
Contributor

The example values for a CR are used when creating a new instance of that CR in the OpenShift web-console. The example attribute json: is not valid for a GrafanaFolder. This Pull Request updates the example to set a custom title using the title: attribute.

@CLAassistant
Copy link

CLAassistant commented Dec 20, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

HVBE
HVBE approved these changes Dec 22, 2023
View reviewed changes
Copy link
Collaborator

@HVBE HVBE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johankok Thanks for the fix, nice catch! LGTM

@HVBE HVBE enabled auto-merge (squash) December 22, 2023 18:06
@HVBE HVBE merged commit 46be4f5 into grafana:master Dec 22, 2023
10 checks passed
HVBE pushed a commit to HVBE/grafana-operator that referenced this pull request Dec 22, 2023
@johankok @HVBE
Update GrafanaFolder example syntax (grafana#1359)
ca9af9e
@johankok johankok deleted the fix/update-grafanafolder-example-value branch December 23, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HVBE HVBE HVBE approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@johankok @CLAassistant @HVBE