Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contactpoint resource #1474

Merged
merged 8 commits into from Apr 3, 2024
Merged

Add contactpoint resource #1474

merged 8 commits into from Apr 3, 2024

Conversation

duncan485
Copy link
Contributor

Any feedback is highly appreciated! Used #1420 as a refrence to create this.

closes #1455

Copy link
Member

@theSuess theSuess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Works well and the overall code quality looks good

I have some concerns around UID handling. The current approach does not allow for renaming of resources, as the UID is retrieved by matching the name.

IMHO a better approach would be to use the Kubernetes UID (part of the object metadata). This way we don't have to do any name matching in the operator and have a consistent UID. We do something similar in the folder resource.

controllers/grafanacontactpoint_controller.go Outdated Show resolved Hide resolved
controllers/grafanacontactpoint_controller.go Outdated Show resolved Hide resolved
Co-authored-by: Dominik Süß <dominik@suess.wtf>
@duncan485
Copy link
Contributor Author

Thanks for the contribution! Works well and the overall code quality looks good

I have some concerns around UID handling. The current approach does not allow for renaming of resources, as the UID is retrieved by matching the name.

IMHO a better approach would be to use the Kubernetes UID (part of the object metadata). This way we don't have to do any name matching in the operator and have a consistent UID. We do something similar in the folder resource.

I agree with you, will change it to use the K8s UID

Copy link
Member

@theSuess theSuess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please fix the last whitespace issue and we're good to merge from my side.

@pb82 @NissesSenap - can you take a quick look at this as well? I've tested this but can't hurt to have someone else take a glance at this as well

@duncan485
Copy link
Contributor Author

Thanks @theSuess , I just removed the whitespace so hopefully passes that last test now

Copy link
Collaborator

@HVBE HVBE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, looking forward to hearing some reports of how well this works for our users, awesome work! thank you @duncan485

@HVBE HVBE merged commit 6855819 into grafana:master Apr 3, 2024
10 checks passed
talron23 added a commit to talron23/grafana-kustomize-fix that referenced this pull request May 16, 2024
…yaml

5.9.0 introduced grafanacontactpoint (grafana#1474), and the needed rbac permissions were added to config/rbac/role.yaml, but not to the kustomize deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Contact Points
4 participants