Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(controllers): make instanceSelector immutable #1525

Merged
merged 4 commits into from
May 13, 2024

Conversation

weisdd
Copy link
Collaborator

@weisdd weisdd commented May 9, 2024

As previously discussed, instanceSelector field must be made immutable to make sure we don't end up having abandoned resources and to be in line with k8s eco-system. The PR contains the required changes.

Fixes: #1519

@theSuess theSuess force-pushed the feat/immutable-instance-selectors branch from 4af95ce to 13fdaaf Compare May 13, 2024 11:34
@theSuess theSuess enabled auto-merge May 13, 2024 11:34
@theSuess theSuess merged commit 27144ee into master May 13, 2024
10 checks passed
@theSuess theSuess deleted the feat/immutable-instance-selectors branch May 13, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] instanceSelectors should be made immutable
2 participants