fix(datasource-controller): replace flaky e2e test for secureJsonData with a unit test #1544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weisdd
requested review from
NissesSenap,
ishanjainn,
theSuess and
pb82
as code owners
theSuess
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
secureJsonDatasourcee2e-test is known to frequently fail.The test was introduced in #1496 to make sure
secureJsonDatais not dropped during marshal/unmarshal process in(r *GrafanaDatasourceReconciler) getDatasourceContent(missingsecureJsonDataitself was fixed in #1500).I think it should be enough for us to just check the contents of
SecureJSONDatafield in a datasource model returned bygetDatasourceContent, so flaky e2e-test can be replaced with a stable unit test.Fixes: #1510