chore(makefile): simplify kustomize CRD updates #1545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weisdd
requested review from
NissesSenap,
ishanjainn,
theSuess and
pb82
as code owners
weisdd
changed the title
weisdd
changed the title
theSuess
reviewed
May 21, 2024
Comment on lines
-174
to
-180
| - name: Check if working tree is dirty | ||
| run: | | ||
| if [[ $(git status --porcelain) ]]; then | ||
| git diff | ||
| echo '::error::run make kustomize-crd or make all and commit changes' | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
Is this check still happening at some point?
There was a problem hiding this comment.
It's needed only in places where something can get generated. Manifests are generated in test job, so it's checked there :)
NissesSenap
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, we have a separate step in Makefile (
kustomize-crd) that copies CRDs todeploy/kustomize/base/crds.yaml.This is a bit inconvenient, because, to update all manifests, we need to run two commands:
make manifestsandmake kustomize-crd.To simplify the flow, I suggest to directly refer to
config/crdfromdeploy/kustomize/base/kustomization.yaml, so we won't need to maintaindeploy/kustomize/base/crds.yaml, and all manifests updates will be covered bymake manifests.