Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workflows): e2e matrix, avoid version skew for kubectl #1550

Merged
merged 6 commits into from
May 24, 2024

Conversation

weisdd
Copy link
Collaborator

@weisdd weisdd commented May 22, 2024

Two changes around e2e-tests:

  • Till this day, we've been using a deprecated version of k8s in our e2e tests. Instead, I suggest to start running tests against the currently supported k8s versions. If you think it's not required at this point, we should at least bump kind version;
  • To avoid version skew for kubectl, I added a step to install client version matching server version.

NOTE: there's a required check on this repository that expects end-to-end job to report its status. Unfortunately, when using name overrides through name field (or it could also be that it had to do with matrix), even though all checks successfully pass, GitHub still shows as if it's waiting for end-to-end job to report its status. Since I don't have enough permissions to experiment with settings, I simply added a placeholder job with end-to-end name to make sure all required checks pass. Please, let me know if you know how to make it better.

@weisdd weisdd changed the title [WIP] feat(workflows): e2e matrix, avoid version skew for kubectl feat(workflows): e2e matrix, avoid version skew for kubectl May 22, 2024
@weisdd weisdd changed the title feat(workflows): e2e matrix, avoid version skew for kubectl [WIP] feat(workflows): e2e matrix, avoid version skew for kubectl May 22, 2024
@weisdd weisdd changed the title [WIP] feat(workflows): e2e matrix, avoid version skew for kubectl feat(workflows): e2e matrix, avoid version skew for kubectl May 22, 2024
@weisdd weisdd merged commit bfca452 into master May 24, 2024
14 checks passed
@weisdd weisdd deleted the feat/e2e-matrix branch May 24, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants