-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INTLY-10438 - Implement conditional serviceaccount creation #347
INTLY-10438 - Implement conditional serviceaccount creation #347
Conversation
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pb82 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@HubertStefanski: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
Description
Spec.skipCreateServiceAccount: True
Relevant issues/tickets
https://issues.redhat.com/browse/INTLY-10438
Type of change
Checklist
Verification steps
These steps verify scenarios where the user will switch from a managed serviceaccount to an unmanaged one and back to a managed account
Spec.skipCreateServiceAccount: True
grafana-serviceaccount
serviceaccount withkubectl get serviceaccounts -n <your namespace>
grafana-serviceaccount
should no longer be recreatedSpec.skipCreateServiceAccount: True
or switch it toFalse